Filtering and categorization for assets

[nylira]

These features still need to be designed, so no rush on implementation.

• Allow users to sort their own portfolio based on the attribute that they care about
• Allow users to search through their own portfolio
• Allow users to customize how many of their assets to show by default
• Potentially separate assets from LP assets via categorization

[luciorubeens]

Design reference for categories:

https://www.figma.com/file/04OF6ZbTo0gLzmFm3kLRkS/app.emeris.com?node-id=3804%3A38364

[maydany]

@nassdonald Hi Nass 😄 I have some questions about this(https://www.figma.com/file/04OF6ZbTo0gLzmFm3kLRkS/app.emeris.com?node-id=3804%3A38364)

to implement the requirements

• Allow users to sort their own portfolio based on the attribute that they care about
• Allow users to search through their own portfolio
• Allow users to customize how many of their assets to show by default
• Potentially separate assets from LP assets via categorization

Q1. what kind of attributes should it have? (dollar value, amount?)

Q2. Could you please make a design for search function and how many of their assets to show by default?🙏

[nassdonald]

Please hold off on any of the UI work here as we're still figuring out the best design approach. The designs in Final screens in Figma were updated in error - apologies for the miscommunication.

[clockworkgr]

@nassdonald @gamarin2 Was this design finalized? Should we have someone pick up the implementation?

CC @eitjuh

[nassdonald]

We decided to have a simple dropdown on the right of each list header that requires sorting/filtering. The dropdown would contain all sorting and filtering (or combination of both) options available for each list. The goal here is not to provide every possible method of sorting and filtering, but rather provide the useful and likely ones. I can't remember which options we decided upon, but we can start that discussion here and figure out what is needed for each list view – CC @benjaminmint

We don't have a standard dropdown menu component yet, but this shouldn't be too difficult to design, as we'll simply follow Material Design's guidelines. Building it on the other hand might be a bit tricky if we want to ensure it follows good usability standards and good HTML practices. For example, often custom JS implementations of a dropdown forget that <select> exists and provides most of the functionality we need, like keyboard navigation. Let's try to avoid reinventing the wheel and find a good solution that we can apply across the board. 🙏

A little bit of a ramble, but you get the point - we need components for this stuff.

[clockworkgr]

ok thanks...

(fwiw, the reason we forget <select> exists is that it's usually a pita to style properly)

In any case a new implementation/PR will be needed for this

[nassdonald]

(fwiw, the reason we forget <select> exists is that it's usually a pita to style properly)

Yeah it's not fun overriding native <select> appearance – here's a nice guide. I think if we can do this once globally, we should be good for most cases. There will be a number of situations where we need native functionality, but don't have time to implement a custom menu – the end goal, of course.

• © Githubissues.
• Githubissues is a development platform for aggregating issues.