search

EmerisHQ / tracelistener

UNIX named pipes-based real-time state listener for Cosmos SDK blockchains
GNU Affero General Public License v3.0
33 stars 8 forks source link

ci(mergify): remove invalid draft condition #86

Closed Pitasi closed 2 years ago

Pitasi commented 2 years ago

Booleans cannot be checked with =false, I don't know the correct way to express this. I just found out that there is a dashboard with a linter (https://dashboard.mergify.com/github/EmerisHQ/repo/tracelistener/config-editor?repositoryName=tracelistener&pullRequestNumber=83) but I can't get it to work so I just removed that conditions (I think draft PRs cannot be merged anyway)

sahith-narahari commented 2 years ago

I feel it's better to have a label like automerge, inorder to keep prs that require wider audience from getting merged with 2 approvals(something like the tilt pr). Maybe this should go into the issue, but would like your thoughts

Pitasi commented 2 years ago

Yaml is still a mistery for me sadly, so I'm approving out of trust.

not a yaml thing but a mergify problem :P

for yaml, everything is just a string

Pitasi commented 2 years ago

I feel it's better to have a label like automerge, inorder to keep prs that require wider audience from getting merged with 2 approvals(something like the tilt pr). Maybe this should go into the issue, but would like your thoughts

I followed the original Stelios issue that said to automerge on 2 reviews. We should pick a "default behaviour" and add a label that can either enable or disable the automerge (e.g. we could add a "mergify-disabled" label or something as described here https://docs.mergify.com/examples/#using-labels-to-enable-disable-merge)