Emerson / ember-form-master-2000

A simple form builder for Ember built as an Ember-CLI addon.
MIT License
40 stars 18 forks source link

[Refactor] Release Version 3.0 #47

Closed g-cassie closed 8 years ago

g-cassie commented 8 years ago

Changes are detailed in the new readme.md. I have been working with @Emerson throughout on this so we are both on the same page.

Some key points:

Emerson commented 8 years ago

This is some really amazing work and represents a much clearer vision than what I had originally written.

If you're interested, I think we should consider moving this into its own Github org. Also going to chat with one of the designers at TWG about maybe getting a hot logo.

g-cassie commented 8 years ago

@Emerson Awesome thanks for the review. I am going to fix the typos. For now I will just remove everything talking about validation. I have a vision for that too now - another big project but mainly drawing on code I have already written in my private repos. I think we can make this a one stop form solution - but keep it pluggable so people can just use the UI stuff if they want or just use the validations stuff.

I don't have a strong opinion but maybe we could shorten the name to "Form Master"? Just because we are using the fm prefix everywhere so it effectively is the name that the addon is being referred to by. This is not a strongly held opinion so feel free to say no to that.

Emerson commented 8 years ago

I think it's still worth leaving in the quip about validation and how passing errors works - just wasn't sure if you had any examples for client side validation a onUserInteraction hook or something.

I'll think over the name stuff and we can connect soon and chat.

g-cassie commented 8 years ago

@Emerson great, just pushed an updated Readme with your changes and some other fixes.