Emerson / ember-form-master-2000

A simple form builder for Ember built as an Ember-CLI addon.
MIT License
40 stars 18 forks source link

[CHORE] Setting on hash deprecation #68

Closed rachel-armstrong closed 2 years ago

rachel-armstrong commented 3 years ago

Priority

Is this PR blocking your next action?

Screenshot

Provide a screenshot, GIF, or video of the change if possible. People like pictures.

What Changed & Why

Explain what changed and why.

Testing

List step-by-step how to test the changes.

Bug/Ticket Tracker

Link to any relevant task(s) or ticket(s) in the bug tracker.

Documentation

Link to any existing documentation that could make the change easier to understand for the reviewer.

In Progress/Follow Up

Mark any areas that are work in progress or require follow up. Note anything that is waiting on other departments or team members.

Legal/Security/Privacy

Call out any legal, security, or privacy concerns.

Third-Party

If any third-party dependencies have been added, explain what they are and why you chose them.

People

Mention people who would be interested in the changeset: Engineer(s) who wrote the old version Designer(s) Product manager (if they’re interested)

rachel-armstrong commented 3 years ago

Not sure if this is the best approach here, but not sure where to go without changing the hash helper

Emerson commented 2 years ago

This was resolved in another PR