Closed spartan782 closed 8 years ago
Hey @spartan782 thanks for this. I have not had an opportunity to test, but I believe @akniffe1 is going to take a closer look. I have a couple of comments looking at the submission:
Also, have you looked into balance? Just curious, I played with it for a bit but never on a large scale.
I have updated the script. I have not looked into balance this was just a simple hack that worked for us and figured it would be a nice default feature to at least try the other FSF servers before just failing out on a file. Also let me know if you need any other changes, we have been using it in our Lab and it seems to work with out any issues.
Excellent, thank you. Agreed this will be useful. I did take a quick peek at the code and noticed the final sub still calling the old function name. Could you to a quick edit on that?
Woops. Good catch thanks.
Thanks. Check it out @akniffe1
I had some time to test this a bit. Worked great! Just some very minor nit picks from my end.
I added the newline to line 70. I didn't see any tab's on my end as line 59 was a comment? Let me know if that works.
Sweet, it's a very minor thing I'm not too worried about it. Thanks so much for this contribution!
Updated changelog and credited @spartan782
Just FYSA @spartan782 , there was a small bug I missed. The first 'test' connection has no data and therefore fails to be interpreted by the fsf server, resulting in a superfluous error to dbg.log. The update just simply passes the success socket onward instead of opening up another connection.
Awesome. Makes sense.
We are running multiple FSF servers and noticed that if the server selected at random is unable to handle the request that the file never makes it to another server. I modified our script to attempt a connection to a random server and only after making a successful connection sending the file. That way if a server doesn't respond we get a warning message and it continues on to the next random server. If no server is available it then raises an error. We also colorized the errors which if you want I can remove them.