search

EmersonElectricCo / fsf

File Scanning Framework
Apache License 2.0
285 stars 49 forks source link

Docker build works again #59

Closed punkrokk closed 7 years ago

punkrokk commented 7 years ago

Fixed Docker so it builds from scratch again. Published updated docker image.

wzod commented 7 years ago

Thanks for the pull request and bringing up the issue with pefile's download URL! Currently working on automating docker builds and will incorporate your changes in a new pull request.

I should have the new pull request later today. If anything, please let me know.

punkrokk commented 7 years ago

My next "step" was going to be to setup an image on Docker Hub to auto build when there was an update to master branch. But that's not something I can do it looks like with out, A.) paying attention and forking, or b.) https://docs.docker.com/docker-hub/github/#linking-docker-hub-to-a-github-account. Happy to help out if you like.

punkrokk commented 7 years ago

reopening

wzod commented 7 years ago

Created PR #60, which includes the changes from PR #59, and created an automated build from Docker Hub to keep up with changes moving forward.

@punkrokk Let me know if this works and/or if I missed anything.

Hope this helps!

punkrokk commented 7 years ago

Wouldn't it make the most sense commit on top of my PR? Instead of making a new one that obsoletes mine? Also - the dockerhub only works when you update on your personal repo, not when fsf is pushed to master.

punkrokk commented 7 years ago

Also that way I can see what you changed and why.

wzod commented 7 years ago

I had a few other changes I needed to include with updating the Dockerfile including updating yara/yara-python along with pushing the automated build for FSF and figured it would be easier to include in one go. I included your changes in PR #60 to resolve the broken links to dependencies.

Regarding Docker Hub, I have a repository for automating the builds from GitHub (i.e. https://github.com/wzod/Dockerfiles ), which should now be a bit more streamlined now that the two are linked together.

Let me know if anything.

Thanks!

jxb5151 commented 7 years ago

Closing since this was rolled into #60.