Open EmiLoKiJu opened 1 year ago
Great work so far, You have come a long way, keep moving forward๐ ๐
You've done well implementing the project requirements, but there are still some issues I think you need to improve on. ๐ ๐
Used correct Kanban templateโ
Used GitHub project๐ โ
[ ] According to the project requirement, each task on the Kanban board is meant to be assigned to a student, I'll suggest you both decide who is Student A
and Student B
and then assign the tasks to yourself accordingly. :smile: :wave: And for the group tasks, it can be assigned to both of you. :+1:
Each of the team members should assign themselves to the correct cards. Decide who will be the assignee for the cards marked as group tasks. All cards on your Kanban board should have assignees.
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!๐๐๐
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @EmiLoKiJu, @abiy006
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! ๐
https://github.com/EmiLoKiJu/Group-capstone
to this https://github.com/EmiLoKiJu/Group-capstone/projects/2
:wave: :smile: Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!๐๐๐
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
https://github.com/EmiLoKiJu/Group-capstone/projects/2
note: 2 people in this group