Closed fazil47 closed 8 months ago
Thanks again for sharing your solution, this is already great! :)
I noticed that when not defining the normal_map
, therefore using the default fallback image (which is a 1x1-white texture), the grass is not pointing up.
To fix that I'm thinking about:
normal_map
in the bundle and set a flag, similar to the HEIGHT_TEXTURE
-flagWhat are your thoughts on this?
I've added a green fallback texture, let me know if you prefer a different solution. I've also replaced grass_normal_map.png
with grass_normal_map_alt.png
because it's effect wasn't noticeable enough.
Current state:
Without rotation:
I haven't tested WASM builds yet, what is the recommended way to do that?
Somehow my new comments are at my last review and not at the bottom.. Well, I think with this should be the last changes to fix all bugs.
I also like the changes in the example camera system.
You can choose if you want to keep them or remove them, though I suggest to also note the keybindings in the examples like the others.
I also think I'd like space
and shift
a bit more because it makes using the camera possible with only one hand (you can ignore this point if you don't agree)
I've remapped the camera movement up to space and down to left shift. With that, should be ready to review.
Also feel free to replace/delete the normal maps I've added.
Attempt at implementing #60. Check this comment for current status.