search

EmiOnGit / warbler_grass

A bevy plugin for creating 3d grass in your game
Apache License 2.0
120 stars 11 forks source link

Make the aabb config option not scale the bundle so i have easier control of scale #82

Closed ethereumdegen closed 1 month ago

ethereumdegen commented 1 month ago

What problem does this solve or what need does it fill?

Make the aabb config option not scale the bundle so i have easier control of scale

ethereumdegen commented 1 month ago

I believe the fix is to remove the last element from this equation

// ---Y_POSITIONS--- position_field_offset.y = texture2d_offset(y_texture, position_field_offset.).r * aabb.vect.y;

EmiOnGit commented 1 month ago

Is this not relevant anymore? @ethereumdegen

ethereumdegen commented 1 month ago

I tried that simple fix and it didnt pan out. I think it is OK to keep it as is for now . There are bigger fish to fry. I actually got this crate working with my setup (besides the crash race cond issue i posted #81 ) check this out

image

EmiOnGit commented 1 month ago

Well first of, this looks great! :) The debug aabb is from the grass entity? I actually don't think that the crate should use the aabb at all for scaling purposes. A Plane should be way better to describe the area since the height of the blades is handled by the height component anyway. Sadly, there is no finite plane in bevy (was added recently). I'll swap out the aabb in the new mayor Bevy upgrade