search

EmicoEcommerce / Magento2Tweakwise-archived

Magento 2 module for Tweakwise integration
Other
9 stars 25 forks source link

Show X more - Placeholder always shows "1" #111

Closed jkekkel closed 4 years ago

jkekkel commented 4 years ago

Issue Brief

In our filtertemplate we often show only 5 items for one filter. After that you get the option to expand and view the other options. We wanted to use the placeholder that shows the number of options that you can view if you expand the filter. Unfortunately this placeholder always shows the number 1. No matter how many values there are.

Environment

PHP Version: 7.1 Magento Version: 2.2.10 Tweakwise Version: 2.1.5 Tweakwise Export Version: 1.5.0 Magento Deploy Mode: development

Steps to reproduce

  1. Use the placeholder for the "show more" option

Actual result

  1. The filtertemplate shows on the frontend "Show 1 more" no matter how many values there are

Expected result

edwinljacobs commented 4 years ago

Hi this has been added to the backlog, we will look into it.

edwinljacobs commented 4 years ago

Hi,

I am not entirely sure on what you mean. As I read it I thought it would be about the show more / show less filters button (see image 'Meer tonen') show-more

As far as I am aware, this text is configurable in the filter settings of the corresponding filtertemplate in tweakwise (go to your template > select the filter > advanced and there you find 'Show more' text and 'Show less' text). I see no way to add a placeholder there. The tweakwise module reads these values and outputs that as the text for the show more button.

I problably misunderstood your issue, if so, can you clarify what goes wrong? Perhaps I misunderstand what you mean by Use the placeholder for the "show more" option?

With kind regards, Edwin Jacobs

edwinljacobs commented 4 years ago

Is this still relevant?

jkekkel commented 4 years ago

Hi Edwin, This is still relevant. I just got this back from our partner: image

Can you do anything with this information? Or do you need something more specific?

jkekkel commented 4 years ago

I just heard from Maxserv that this was apparently something they actually did do themselves and that we didn't use any placeholders from you. Sorry for the inconvenience.