search

EmicoEcommerce / Magento2Tweakwise-archived

Magento 2 module for Tweakwise integration
Other
9 stars 25 forks source link

Can't close filter popup after ajax filtering on mobile #144

Closed vasiok32k closed 3 years ago

vasiok32k commented 3 years ago

Hi all, There is bug on POP on mobile when using ajax filtering. I can't close filter popup after ajax filtering on POP on mobile.

I investigated issue and found that response rendering whole filter sidebar including Filter Title that contain cross icon on mobile and is actually toggle for close the popup when you will click on cross icon.

I have a solution for that so I could create PR to fix that or you could create you own fix for that.

Version of "emico/tweakwise" module is "v3.2.1".

Please let me know about approving of that bug and acceptable way to fix it.

Thanks for future help.

stijnbernards commented 3 years ago

Hi Vasyl,

Sure you can go ahead and create a merge request for this issue. Do you need any further assistance with this?

vasiok32k commented 3 years ago

Hi stijnbernards Created PR https://github.com/EmicoEcommerce/Magento2Tweakwise/pull/145

stijnbernards commented 3 years ago

Hi,

Thank you for your contribution! I'll check and test this MR in a bit!