EmicoEcommerce / Magento2Tweakwise-archived

Magento 2 module for Tweakwise integration
Other
9 stars 25 forks source link

Ajax filtering not working with pagination #165

Closed Alainvdz99 closed 2 years ago

Alainvdz99 commented 3 years ago

Issue Brief

When being on the next page of a plp, filtering wont work anymore if there is only 1 page of products left after the filter. Problem is that url parameter "p=2" (2 stands for the pagination) will stay in the url when there is only 1 page left.

Environment

Steps to reproduce

  1. Enable Ajax filtering
  2. Go to a PLP with more than 24 products
  3. Go to the next page (page 2)
  4. Use a filter which will result with not having more than 24 products

Actual result

  1. Filtering will not work
  2. Request url to tweakwise will return 0 items because its using page 2 (tn_p1=2 in url), when using tn_p1=1 in the url, it does give the correct items back Screen Shot 2021-06-18 at 14 14 16

Expected result

List the expected results as a bullet list of expectations

simonjanguapa commented 3 years ago

We are experiencing this issue as well.

CyberSecutor commented 3 years ago

We are also experiencing this with Magento 2.3.4-p1 and module version 3.3.4

Hnto commented 2 years ago

@Alainvdz99 Issue has been fixed in v4.0.4.