search

EmicoEcommerce / Magento2Tweakwise-archived

Magento 2 module for Tweakwise integration
Other
9 stars 25 forks source link

Incorrect renamed tweakwise_filter_whitelist(_code) / tweakwise_filter_values_whitelist(_code) attributes #232

Closed pmzandbergen closed 2 years ago

pmzandbergen commented 2 years ago

What The following commit breaks (some) existing installations: https://github.com/EmicoEcommerce/Magento2Tweakwise/commit/da49f6c9cc269c6d353f313a8f9967fa633c7f32

Why The patch has already been applied with tweakwise_filter_whitelist_code and tweakwise_filter_values_whitelist_code. Updating does not re-apply this patch with the new attribute names.

_Please note that the changes are both under tag 4.1.2. Maybe this tag has been re-created, otherwise I don't understand how the patch has been applied with the _code suffixes at our environments, since we only used tagged versions._

pmzandbergen commented 2 years ago

Seems to be a local issue, can't reproduce. Closed.