<li> element without <ol> or <ul> element - Githubissues

EmicoEcommerce / Magento2Tweakwise-archived

Magento 2 module for Tweakwise integration

Other

9 stars 25 forks source link

<li> element without <ol> or <ul> element #50

Closed hostep closed 6 years ago

hostep commented 6 years ago

Issue Brief

Frontend developers complaining about incorrect html nesting.

Environment

PHP Version: (7.0.31)
Magento Version: Magento Commerce Cloud 2.2.5
Tweakwise Version: test branch (80a2933)
Tweakwise Export Version: 1.1.4
Magento Deploy Mode: production & development
Third party modules: a lot

Steps to reproduce

Look at the file https://github.com/EmicoEcommerce/Magento2Tweakwise/blob/80a2933/src/view/frontend/templates/product/navigation/view.phtml#L69-L71

Actual result

See a <li> element without <ul> or <ol> wrapper element

Expected result

See a <li> element which is wrapped in a <ul> or <ol> element or something completely different then a <li> element

hostep commented 6 years ago

Updated issue, was pointing to the incorrect phtml file, sorry about that. Is only for the test branch at the moment.

hostep commented 6 years ago

Let's close this, since it was fixed in https://github.com/EmicoEcommerce/Magento2Tweakwise/commit/4b1aed5e35a01bb7c9ddd249431f616185c56046#diff-f527052dfdff83509901625f3b99a95b