EmicoEcommerce / Magento2Tweakwise-archived

Magento 2 module for Tweakwise integration
Other
9 stars 25 forks source link

Add default `tn_cid` in Product Search Request #61

Closed jasperzeinstra closed 5 years ago

jasperzeinstra commented 5 years ago

We've got multiple stores connected to Tweakwise. At this moment when doing a search a tn_cid parameter isn't added to the request. This results in an API result of the same products from different stores. Product ID 1 is exported with itemno as 100011, 100021 and 100031.

This PR sets a default root category if no category is set.

edwinljacobs commented 5 years ago

Hi Jasper,

Thanks for the pull request, this seems to fix the issue for multiple store views and is therefor accepted. We added some refactoring to this class and also its parent classes because there are some calls on getStore() which could throw exceptions which are not handled right now. The release is soon to follow

With kind regards, Edwin Jacobs

edwinljacobs commented 5 years ago

This has been released in 1.4.6

With kind regards