search

EmicoEcommerce / Magento2Tweakwise-archived

Magento 2 module for Tweakwise integration
Other
9 stars 25 forks source link

Some config settings not implemented #84

Closed edwinljacobs closed 5 years ago

edwinljacobs commented 5 years ago

The following config settings are not implemented and should be removed:

<field id="log" translate="label,comment" type="select" sortOrder="40" showInDefault="1" showInWebsite="1" showInStore="1">
                    <label>Log enabled</label>
                    <comment>Log requests to tweakwise.</comment>
                    <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                </field>
                <field id="log_developer" translate="label,comment" type="select" sortOrder="50" showInDefault="1" showInWebsite="1" showInStore="1">
                    <label>Log Developer</label>
                    <comment>Only log developer IP's</comment>
                    <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                    <depends>
                        <field id="enabled">1</field>
                        <field id="log">1</field>
                    </depends>
                </field>

These fields do not have a corresponding getter for their values in the config model. We suggest removing them

edwinljacobs commented 5 years ago

These settings will be removed in the next release