search

EmicoEcommerce / Magento2Tweakwise

Magento 2 module for Tweakwise integration
Other
4 stars 16 forks source link

Introduce some kind of automated linting (and fixing) to improve code quality #134

Closed Swahjak closed 7 months ago

Swahjak commented 11 months ago

Issue Brief

In example; the following class has about 24 use statements, while only 2 are actually used. This is probably due to some refactoring at a point in time, but from a quality perspective this doesn't give me a lot of confidence. Not by any means saying that it lacks quality, I haven't gone into the code enough to say anything about it. But if such a simple task, that can be easily automated, is neglected it doesn't make me (the customer) very confident about the overall quality.

Also; adding code quality tools and linters makes it much easier to contribute.

Environment

-

Steps to reproduce

-

Actual result

- Expected result

-

ah-net commented 10 months ago

Good idea. I've added this this to our backlog. The plan is to add an phpcs linter to our CI pipeline. I'll close this issue for now since it's on our backlog.

Swahjak commented 10 months ago

I would prefer for this issue to stay open, since it is on you backlog but hasn't actually been resolved. That way I can be notified, if and, when this issue has actually been resolved without having to monitor release notes.

ah-net commented 10 months ago

@Swahjak I'll understand. I'll reopen the issue for now.

ah-net commented 7 months ago

@Swahjak We now have an linter in our workflow. In the next release there will be changes to improve the code quality.