Add setting to enable/disable showing parent category in layered navigation.

leonhelmus commented 2 months ago

Issue Brief

Feature request: In \Tweakwise\Magento2Tweakwise\Model\Client\Request::addCategoryFilter it is expected that everyone wants to show all the parent categories, but not all clients would want that. By adding a setting like "show_parent_category_filter" and if disabled don't add the parent categories in the category filter.

    public function addCategoryFilter($category)
    {
        $ids = [];
        if (is_numeric($category)) {
            $ids[] = $category;
            return $this->addCategoryPathFilter($ids);
        }
        /** @var Category $category */
        $parentIsRoot = in_array(
            (int) $category->getParentId(),
            [
                0,
                1,
                (int) $category->getStore()->getRootCategoryId()
            ],
            true
        );
        if (!$parentIsRoot) {
            // Parent category is added so that category menu is retained on the deepest category level
            $ids[] = (int) $category->getParentId();
        }
        $ids[] = (int) $category->getId();

        return $this->addCategoryPathFilter($ids);
    }

This function could change to something like this:

    public function addCategoryFilter($category)
    {
        $ids = [];
        if (is_numeric($category)) {
            $ids[] = $category;
            return $this->addCategoryPathFilter($ids);
        }
        /** @var Category $category */
        $parentIsRoot = in_array(
            (int) $category->getParentId(),
            [
                0,
                1,
                (int) $category->getStore()->getRootCategoryId()
            ],
            true
        );
        if (!$parentIsRoot && $this->scopeConfig->getValue(self::XML_SHOW_PARENT_CATEGORY_IN_FILTER)) {
            // Parent category is added so that category menu is retained on the deepest category level
            $ids[] = (int) $category->getParentId();
        }
        $ids[] = (int) $category->getId();

        return $this->addCategoryPathFilter($ids);
    }

This way clients can decide themselves if they want to show the parent categories.

Environment

PHP Version: 8.1
Magento Version: 2.4.5
Tweakwise Version: 5.7.5
Tweakwise Export Version: 6.0.0
Magento Deploy Mode: (production|development)
Third party modules:

Steps to reproduce

Install Magento from master branch.
[Example] Export configurable product with multiple children and 2 configurable attributes to Tweakwise.
[Example] Configure color filter in Tweakwise
...

Actual result

[Example] Error message appears: "Cannot save quote".
[Screenshot, logs]
...

Expected result

List the expected results as a bullet list of expectations

[ ] [Example] Configurable product added to the shopping cart.
[ ] ...

ah-net commented 2 months ago

@leonhelmus Do you mean showing the parent categories in the categorie filter? If you don't want to show the parent categorie in the categorie filter, you can set the categorie filter in Tweakwise to link. Then no parent categories are shown.

leonhelmus commented 2 months ago

Ah really, i did not know that thanks for mentioning it.

EmicoEcommerce / Magento2Tweakwise