search

EmicoEcommerce / Magento2TweakwiseExport-archived

Magento 2 module for Tweakwise export
Other
6 stars 16 forks source link

Compatibility with Magento 2.4.4 and Php 8.1 #129

Closed gdvisser closed 2 years ago

gdvisser commented 2 years ago

Issue Brief

Most recent Magento version (2.4.4) requires Php 8.1. Tweakwise Export module however is not compatible with Php 8.1.

Environment

Steps to reproduce

  1. Install Magento 2.4.4 on Php 8.1.from develop branch.
  2. Run bin/magento setup:di:compile on command line.

Actual result

Errors are thrown like:

  1. Fatal error: During inheritance of IteratorAggregate: Uncaught Exception: Deprecated Functionality: Return type of Emico\TweakwiseExport\Model\Write\EavIterator::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice.
  2. Fatal error: During inheritance of IteratorAggregate: Uncaught Exception: Deprecated Functionality: Return type of Emico\TweakwiseExport\Model\Write\Products\Collection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice.

Might also be other issues. Module needs to be thoroughly tested on php 8.1.

Expected result

Module working with Php 8.1.