search

EmicoEcommerce / Magento2TweakwiseExport-archived

Magento 2 module for Tweakwise export
Other
6 stars 16 forks source link

Fix missing table prefix catalog_category_product_index #60

Closed govereem closed 6 years ago

govereem commented 6 years ago

This solves the issue of missing table prefix for catalog_category_product_index

edwinljacobs commented 6 years ago

Hi thanks for the pull request, I already made a branch (see commit: https://github.com/EmicoEcommerce/Magento2TweakwiseExport/commit/8996fc8489d502a4ee2b2618594007f3932a236a) to fix this issue. The decorator itself has a method getTableName which does the same as in this pull request.

see https://github.com/EmicoEcommerce/Magento2TweakwiseExport/blob/master/src/Model/Write/Products/CollectionDecorator/AbstractDecorator.php

I was planning on merging this today.

govereem commented 6 years ago

Okay nice, your solution looks nicer for changing $connection->getTableName() to $ths->getTableName(). My solution can be skipped.