search

EmicoEcommerce / Magento2TweakwiseHyva-archived

Hyvä Themes Compatibility module for Emico_Tweakwise
Other
4 stars 1 forks source link

Add hyva_ prefix for the layouts in case this module is enabled on a luma store #25

Open wahidnory opened 2 years ago

wahidnory commented 2 years ago

Currently the layouts are also enabled on a Luma store, this breaks in certain cases the toolbar and no pagination is therefore shown.

With the prefix of hyva_ the layouts are only rendered on a Hyva storefront and Luma themes continue to work.

Additional documentation from hyva is found here: https://docs.hyva.io/hyva-themes/writing-code/the-hyva_-layout-handles.html

ah-net commented 2 years ago

Tested this, and it works. But it causes an issue with the loading icon with ajax requests. The loading icon isn't triggered anymore on the second page loaded, and you can't see that it's trying to load an ajax page in the background.

Not sure why the loading icon isn't triggered anymore, but it only happens after the first ajax call.