search

EmilDohne / PhotoshopAPI

A modern and performant C++20 read/write parser of Photoshop Files (*.psd and *.psb) with fully fledged Python bindings hosted on PyPi
https://photoshopapi.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
94 stars 9 forks source link

Add support for ARM based Mac chips #61

Open EmilDohne opened 6 months ago

EmilDohne commented 6 months ago

This appears to only fail on compilation of our AVX2 intrinsics which we can simply opt out of if we detect arm based machines and in the future we can add arm based intrinsics

EmilDohne commented 6 months ago

Initial support for this has been added but unfortunately due to issues with GCC and Xcode15 we cannot run the tests as expected failures which throw std::runtime_error() instead segfault the processes. The tests up to the expected failures do run properly which is why we will temporarily add a workaround for these disabling them at compile time. This is unfortunate as it reduces test robustness but until a fix is implemented this will have to be the implementation

EmilDohne commented 6 months ago

As I am adding support for this the same issues propagate to the python bindings when using e.g. a 

try:

except RuntimeError:

code block as ARM-based macs will segfault here as well. Despite support for this being added this ticket will remain open until we find a solution to this problem (likely just waiting for xcode updates to propagate to gh runners)