EmilHernvall / tregmine

The tregmine plugins
http://tregmine.info/
BSD 4-Clause "Original" or "Old" License
8 stars 10 forks source link

Untested - RemItems now removes arrows, Merged nuke - With more features. #245

Closed lDiverse closed 10 years ago

lDiverse commented 10 years ago

RemItems now removed arrows on the floor after an issue on the server today. I also merged nuke with this command for simplicity, I also added an extra parameter to remove a specific mob type rather than all.

lDiverse commented 10 years ago

I duplicated that bit of the code based on the old nuking system. So I didn't see any problem with it as we haven't had any problems like that with /nuke.

EmilHernvall commented 10 years ago

Maybe we should call this nuke rather than remitems, since it's a bit shorter? I think the setHealth() thing is probably down to @einand doing it that way for some reason. Not sure why, but it's possible that a remove method simply didn't exist back then.

lDiverse commented 10 years ago

ngl, I did forget to rename this. You can rename it to what you want ;p

einand commented 10 years ago

Back in the old days remove was faulty and failed time to time. If that works now feel free to remove it.

Ein Andersson

30 dec 2013 kl. 19:58 skrev Emil Hernvall notifications@github.com:

Maybe we should call this nuke rather than remitems, since it's a bit shorter? I think the setHealth() thing is probably down to @einand doing it that way for some reason. Not sure why, but it's possible that a remove method simply didn't exist back then.

— Reply to this email directly or view it on GitHub.

lDiverse commented 10 years ago

Renamed to '/nuke' and using .remove(); rather than .setHealth(0);

EmilHernvall commented 10 years ago

I'd like to see this tested before I merge it. It also needs a rebase.