search

EmilHernvall / tregmine

The tregmine plugins
http://tregmine.info/
BSD 4-Clause "Original" or "Old" License
8 stars 10 forks source link

Banking update #345

Open lDiverse opened 10 years ago

lDiverse commented 10 years ago

So... This is the first commit for the upgraded banks.

These bankers do pretty much what the current banks do, but with a lot of changes. This only converts to the newer bank system, and replaces the iron block with an NPC with custom AI.

I will be adding further components such as the outposts as discussed - but I wanted to release this part as this core is all done and ready. I want to get this on the test server so we can do some heavy testing to make sure it's all functional prior to moving to the main server.

As discussed on Skype - Transfer ALL money to players wallets. Take a backup prior to all these changes, to be safe.

lDiverse commented 10 years ago

That latest commit (Few extra commits) contains three things: An upgraded .gitignore for some unknown reason A craftbukkit.jar to go alongside the library - as this is needed for the JSON messages

and also the SQL file. I made a new one because I just exported my database. Cherry pick what you need from that file and delete it (merge whats needed with the schema_changes)

Will be working on more features tomorrow

EmilHernvall commented 10 years ago

Pushing this to a separate branch for now. We'll merge it to master once it's ready. Keeping this PR open in the meantime.

lDiverse commented 10 years ago

Ignore any commits after this message for time being.

lDiverse commented 10 years ago

So at this point, everything is refactored and sorted out. There is a few interfaces missing which I need to design and interlink with the commands. Then all the bankers should be back to normal.

I've not done ANY testing what so ever of this new system, so crossing my fingers :P

lDiverse commented 10 years ago

Done a good amount of testing with Richard once again.

Theres a bug with chat, where people can see you typing and vice versa. If an account is updated whilst someone else is viewing the account, they have to log out for it to update. The bankers lose their AI at some occasions (I think its when the chunk unloads they lose it)

lDiverse commented 10 years ago

Still need to do a tonne of work on interfaces, Work on the admin interface. Attempt to fix why some people (so far only one / five people) can't click the buttons. If can't work out whats causing the issue - Remove internalCommands and make them normal. Sort out the owner interface, add ability to rename, change robes, change location. Fix chat, Stop people accesing accounts if someone already is. Work out what's wrong with the AI, and fix that.

lDiverse commented 10 years ago

Just to justify why I committed the fixes Emil made. Needed to add a location parameter incase the villager is moved between unloading and loading.

lDiverse commented 10 years ago

Known bugs:

lDiverse commented 10 years ago

Admin interface has now been created. This can be accessed by admins via "/bank admin" and is prompted to be used when they attempt to create a banker when they in fact can't because it's not registered.

Granted more admins will probably use the command variation rather than the interface, but for completion sake and the fact I don't want people turning around to me and saying "how do I add bankers" etc - I added it.

To add bankers or to register the zone as a bank is as simple as running /bank admin and then clicking on the corresponding button.

Done some misc fixes and changes as well.

lDiverse commented 10 years ago

Now that GitHub has come back from a little time down, I could finish the commits.With this I added a new database field: banker_id (int 10) Auto Increment Renamed banker_id to banker_uuid

Set all that out, added (and fixed) the ability to set a bankers location.

Bit of a bug with DB - Couldn't fix, so gave up for today.

lDiverse commented 10 years ago

I was tired.. okay? Don't judge ;p

lDiverse commented 10 years ago

Will be returning to finish this shortly.

EmilHernvall commented 10 years ago

I can probably find some time this week if you need me for something. :)

lDiverse commented 10 years ago

@EmilHernvall What's your Skype? (Got a new one, old one was being attacked so much)

lDiverse commented 10 years ago

According to my previous debugging and bug reporting, the only issues were AI (which I know to now have been fixed, more testing can be done), Chat (which is not related to this, it's a bug with the core plugin which I have posted a fix for (at least I hope it's a fix)) and a client side button press which I have commands in place for them.

Meaning when you have some time, i'd like to compile everything and get it on the test server so we can make sure it works.