Took a pass at updating just this one step to run by you and get feedback. This pull request includes:
The updated class name for the almanac objects, otherwise nothing works
Switch to returning integer binary variables rather than boolean, to more closely align with step_holiday which I think these steps are most closely related to
Adds the keep_original_cols argument with a default of TRUE as in step_holiday
Refactors the bake method slightly, again to align with the approach in step_holiday and to replace purrr functions with lapply.
Updates the tests to align with the modifications above
Basically, I just wanted to take a stab at a single function and get a sense of whether any of this is in the general direction you'd like to see.
Took a pass at updating just this one step to run by you and get feedback. This pull request includes:
step_holiday
which I think these steps are most closely related tokeep_original_cols
argument with a default ofTRUE
as instep_holiday
bake
method slightly, again to align with the approach instep_holiday
and to replacepurrr
functions withlapply
.Basically, I just wanted to take a stab at a single function and get a sense of whether any of this is in the general direction you'd like to see.