Don't rely on BASE_DIR being a Path.

EmilStenstrom / django-components

Create simple reusable template components in Django.

MIT License

973 stars 62 forks source link

Don't rely on BASE_DIR being a Path. #385

Closed EmilStenstrom closed 3 months ago

EmilStenstrom commented 3 months ago

Fixes #381

I went through all usages of BASE_DIR in the project and made sure all of them are safe for strings. Didn't touch sampleproject which still defined BASE_DIR as a Path.

dylanjcastillo commented 3 months ago

The fix looks good. And sorry, I introduced this bug in a previous fix.

EmilStenstrom commented 3 months ago

@dylanjcastillo Thanks for reviewing! Don't worry, this project is littered with my little omissions like this. We just fix them and release a new version!