search

EmilStenstrom / django-components

Create simple reusable template components in Django.
MIT License
953 stars 59 forks source link

refactor: fix slot context behavior #445

Closed JuroOravec closed 3 weeks ago

EmilStenstrom commented 4 weeks ago

Don't forget to add a tests that catches the broken behavior!

JuroOravec commented 3 weeks ago

@EmilStenstrom I've fix the issues and and tests :)

JuroOravec commented 3 weeks ago

Agree that ideally there should be only one way to do it. But since personally I'd prefer the isolated option as the way, in the other discussion we've suggested the prefer_root, and users may have been used to the option that's now called allow_override, then I'm not confident in setting the behavior to be only a single way, without providing users a way to go back.

Maybe we could decide on a single behavior and remove the setting as part of the v1.0 release? What do you think?

Update: I've moved the discussion on removing the options to https://github.com/EmilStenstrom/django-components/issues/450, so I can merge this, so the fix can be released.