EmilStenstrom / django-components

Create simple reusable template components in Django.
MIT License
953 stars 59 forks source link

feat: merge context settings, replace if_filled tag with var #465

Closed JuroOravec closed 2 weeks ago

JuroOravec commented 2 weeks ago

This MR:

This is a big MR, but also about 2/3 of it are documentation and test changes.

Closes https://github.com/EmilStenstrom/django-components/issues/280 Closes https://github.com/EmilStenstrom/django-components/issues/450

dylanjcastillo commented 2 weeks ago

This looks great. And the new documentation section about slot rendering is super useful. Thank you, Juro!

The only thing I noticed is that there were some small formatting changes in the README. I wonder if we should use a pre-commit hook for md files? Because whenever I change the README, the same thing happens.

JuroOravec commented 2 weeks ago

@dylanjcastillo Thanks!

On README formatting - Yeah I think I would be good to have README linted too, do you know how to set it up?

dylanjcastillo commented 2 weeks ago

I’ll give it a go in the coming days!