search

EmilStenstrom / django-components

Create simple reusable template components in Django.
MIT License
953 stars 60 forks source link

feat: Support both sync and async in ComponentDependencyMiddleware #466

Closed TheSteveBurgess closed 2 weeks ago

TheSteveBurgess commented 2 weeks ago

Hi,

PR for converting the middleware to async as mentioned here (https://github.com/EmilStenstrom/django-components/issues/464)

This is working fine for me both sync and async via Daphne.

TheSteveBurgess commented 2 weeks ago

Well, that looks like I've broken something :)

Let me take a look why the tests are failing.

JuroOravec commented 2 weeks ago

@TheSteveBurgess thanks a lot for the PR! 🚀 It looks great! There's one typo, let's see if things work after that :)

JuroOravec commented 2 weeks ago

I ran the tests locally, everything should be passing after fixing the function signatures

TheSteveBurgess commented 2 weeks ago

Amazing! Thanks for that :)

JuroOravec commented 2 weeks ago

Merged! @TheSteveBurgess thanks a lot again :) I plan to release this as part of v0.70 together with https://github.com/EmilStenstrom/django-components/pull/465 later today