search

EmilZach / Sentence-Crusher

A Python game for crushing sentences.
0 stars 1 forks source link

Get sorted highscore is in the wrong class - what is the right class? #21

Closed Arxcis closed 8 years ago

EmilZach commented 8 years ago

Due to StorageGuy writing the highscore to a text file, I would say the function should go from DataGuy to StorageGuy.

Arxcis commented 8 years ago

It is already in StorageGuy..

  1. mar. 2016 4.14 p.m. skrev "Emil Teigland Zachariassen" < notifications@github.com>:

Due to StorageGuy writing the highscore to a text file, I would say the function should go from DataGuy to StorageGuy.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/EmilZach/Sentence-Crusher/issues/21#issuecomment-203957246

EmilZach commented 8 years ago

Not in s_data.py, I think...

EmilZach commented 8 years ago

I can't check that right now, so I am not completely sure.

Arxcis commented 8 years ago

I checked and completely sure ;)

  1. mar. 2016 4.27 p.m. skrev "Emil Teigland Zachariassen" < notifications@github.com>:

I can't check that right now, so I am not completely sure.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/EmilZach/Sentence-Crusher/issues/21#issuecomment-203964427

Arxcis commented 8 years ago

OK her er mitt forslag:

Til nå har DataGuy-klassen fungerte på følgende måte:

Attributter:

Metoder:

Forslaget mitt er å utvide virkeområdet til DataGuy , til også å inkludere metoder som går ut på å generere nye data, på grunnlag av data som allerede er lagret i DataGuy. Dette gjelder funksjonen calc_points() i LogicGuy og get_sorted_highscorelist() i StorageGuy.

Foreslår å endre navnet på disse to metodene til og plassere dem i DataGuy ;)

mvh Jonas

On Thu, Mar 31, 2016 at 4:31 PM, JoJo jonas.solsvik@gmail.com wrote:

I checked and completely sure ;)

  1. mar. 2016 4.27 p.m. skrev "Emil Teigland Zachariassen" < notifications@github.com>:

I can't check that right now, so I am not completely sure.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/EmilZach/Sentence-Crusher/issues/21#issuecomment-203964427

Arxcis commented 8 years ago

Har blitt enig med meg selv, og flyttet get_sorted_highscore() til DataGuy-klassen hvor den kan føle seg mer hjemme. Have a look guys.