PID output decimal dot - Githubissues

Emile666 / stc1000_stm8

STC1000p for the STM8 microcontroller (HW version WR-032)

GNU General Public License v3.0

45 stars 10 forks source link

PID output decimal dot #5

Closed zstomp closed 6 years ago

zstomp commented 6 years ago

In PID output display mode (PWR button pressed twice), decimal dot is not showing. I think it would be less confusing if it showed.

Emile666 commented 6 years ago

Good point! Initially I calculated pid_output as a percentage, but since all temperatures are in E-1 °C, it was more convenient to also calculate pid_out in E-1 (%). I can do two things:

Drop the E-1 % and display pid_out in %
Display it as E-1 % with a dot (e.g. 85.3) and display 100 % as '100' Any comments on these two options? What do you prefer?

zstomp commented 6 years ago

I think I'm a little bit more inclined towards second option. And thanks for the awesome firmware!

Emile666 commented 6 years ago

Thanks! The call to display the PID output percentage is given in stc1000p.c, line 425. Replace LEDS_TEMP with a new define (e.g. LEDS_PERC). In stc1000p_lib.c, lines 170-200, the value_to_led() function is given. This function needs to be updated to also display a percentage.