search

Emiliano-Bucci / react-spring-carousel-js

A new Carousel experience for the modern Web
https://react-spring-carousel-js.emilianobucci.com
80 stars 6 forks source link

withLoop broken when itemsPerSlide equals the length of the provided items #9

Closed thomasgrivet closed 3 years ago

thomasgrivet commented 3 years ago

Hello!

I was playing with the differents options when I found this weird behaviour : When the option itemsPerSlide is the same as the length of the provided items, the loop doesn't work as expected. You can see in the video that the bottom carousel - with a itemsPerSlide: 5 and items.length: 6 - works perfectly whereas the top one - with a itemsPerSlide: 5 and items.length 5 - doesn't. I recreated this issue in a codesandbox here : https://codesandbox.io/s/epic-feistel-f5fgc

Again, thanks a lot for the work you put in this project, it is awesome!

Emiliano-Bucci commented 3 years ago

@thomasgrivet Hi! Thanks for the feedback; issue (and other minor correlated) should be fixed now in 1.9.6. Please let me know if works for you! :)

thomasgrivet commented 3 years ago

1.9.6 fixes it! Thanks a lot!