EmilsGithub / Clutter-Mod-Repository

The Github repository for the Minecraft mod Clutter
MIT License
6 stars 5 forks source link

[Bug/Suggestion] Sulfur and Onyx #20

Open Ultimushadow opened 1 year ago

Ultimushadow commented 1 year ago

While testing I found both Sulfur blocks and Onyx ore lack a proper tool to break them. Also, I noticed in EMI that the Sulfur block does not properly display its drops, both the block and sulfur items won't show it (but Sulfur shows it's dropped from Onyx ore). Also, fortune does not work on the Sulfur item when breaking Sulfur blocks or Onyx ore, not sure if that was intentional

Now, I know renewability has not been added to these items yet, so I was going to suggest some ways to implement this, as well as a potential change to Onyx. I've taken a lot of inspiration from these materials real life counterparts but in a way I think suits the game and the mod pretty well.

Onyx is known for being a dark, very dark colored gemstone, and actually most often occurs in calcite of all things, so having it be in geode form makes a lot of sense, but I think that you could split Onyx away from Sulfur as the two don't quite have much to do with each other - well they kinda do. I think that you could get away with making the gemstone more like vanilla in order to have it be renewable. Keep the current Onyx textures, but rename them to "Dull Onyx", because most real world onyx does look grey or dull. That block would be what spawns inside the geode, along with a "budding" variant to grow Onyx crystals. But, interestingly, you can chemically form dull onyx into black onyx with sulfuric acid! So, you could throw in a recipe to combine Sulfur and Dull Onyx (since I figure adding acid is a little out of the way for this mod) and make Black Onyx, which could get a much darker block set to reflect the stone most people recognize. At present, the Onyx trim is only a little darker than Netherite, Black Onyx would be almost entirely black for the darkest trim possible!

As for sulfur renewability, of course real world sulfur is formed with water and that's lame cuz it fits the vibe of the Nether very well so I'm going to just pretend that doesn't exist. Since sulfur is meant to be a naturally occurring substance, it could still be found in veins similar in size to Coal Ore in the Overworld. Or, better yet, add a new feature to the Nether in the form of a volcano - a small one, that is. Sulfur tends to be associated with volcanoes or hot springs, as an example the Better End mod adds their own version of Sulfur that generates in giant hot springs (in the end though, obviously). If you go the volcano route though, you could add little deposits of Sulfur at the bottom, they would just be little mounds 10-15 blocks high with a one block hole dropping down 50 or so blocks into that deposit. However, to make it renewable, when a Blaze is killed by water damage, it should drop Sulfur rather than a Blaze Rod. This makes it an interesting goal for someone looking to get more of the stuff. At present though, Sulfur does not have a lot of uses, so adding a recipe to make Gunpowder and some kind of fertilizer would be my suggestion. Since mining in the Nether or moving a Blaze to the Overworld for an auto farm/bringing Splash Water Bottles to the Nether is kind of a hassle, it should be able to craft a significant amount of Gunpowder/fertilizer. Maybe one Sulfur and one Coal makes 4 Gunpowder, and crafting one Bonemeal with one Sulfur gives 3 Bonemeal back. Irl, sulfur actually tarnishes copper and silver. Now, I know your silver doesn't tarnish, but using Sulfur to oxidize Copper blocks without all the waiting could be an awesome feature! Also, it burns blue in real life!

EmilsGithub commented 1 year ago

Bugs(?):

Sulfur blocks and Onyx ore lack proper tools for breaking - Both use the shovel.

Sulfur block doesn't properly display drops in EMI; neither block nor items show them, but Onyx ore shows that it drops Sulfur. - Not sure about this, sulphur does drop from onyx ores, but maybe I should change that.

Fortune doesn't work on Sulfur from Sulfur blocks or Onyx ore; unclear if intentional. - Sulphur from the blocks is not supposed to be affected by fortune, think of them like glowstone or clay blocks. The same applies to the ore, might change that though.

Onyx

Separate Onyx from Sulfur; introduce "Dull Onyx" that spawns in geodes, along with a budding variant to grow crystals. - Actual Geodes might be a good idea.

Create Black Onyx by combining Sulfur and Dull Onyx, giving a very dark appearance. - Maybe.

Current Onyx trim could be darker, similar to Black Onyx. - Done and done.

Sulphur

Can be found in veins like Coal Ore or near volcanoes in the Nether.- Changed the way it generates, now generates in ore veins in basalt deltas.

Blaze killed by water damage should drop Sulfur instead of a Blaze Rod, making it renewable. - Yes, great idea.

Craft Gunpowder (1 Sulfur + 1 Coal = 4 Gunpowder) and fertilizer (1 Bonemeal + 1 Sulfur = 3 Bonemeal). - Gunpowder yes, might change the recipe though. Bonemeal, not sure.

Use Sulfur to oxidize Copper blocks without waiting; reflects real-life interaction with copper and silver. - Fantastic idea!

Ultimushadow commented 1 year ago

Great to hear! Thanks for all the work on the mod!

The reason I mentioned Fortune and Sulfur is that both Glowstone and Clay are affected by Fortune. They normally drop 1 item with each level of fortune increasing it by one, because that maxes out at 4 and it takes 4 items to make the block, which completes the loop.

As for the Sulfur recipes, I only included those so the item would have some more use cases. If the Bonemeal doesn't resonate with you, all is well, just wanted to give as may ideas as I could!

I'm very much looking forwards to that oxidization idea, is there a way you can generalize it to work with all types of copper blocks including modded blocks that implement oxidization, or will you have to hardcode it? If you end up hardcoding it, I also suggest a config option to add blocks that can be changed by Sulfur so we can add our own compatibility without having to code anything directly!

EmilsGithub commented 1 year ago

I'm not hardcoding the sulphur items functionality. As long as the block the item is used on implements "Oxidzable" it should work, doesn't matter if it's vanilla or modded.

Also, clay is not affected by fortune, Glowstone is but barely.

Ultimushadow commented 1 year ago

That's great to hear!

Ah, apologies, you are correct, but it also drops 4 per block by default so it's unneeded anyways. My intention bringing it up was not to focus on the fortune aspect, merely the block being crafted by 4 items and the vanilla convention of dropping enough items to do so, whereas Sulfur only dropped 1 item during my testing.

EmilsGithub commented 1 year ago

It's supposed to drop 1 - 3, or the whole block when using silk touch. I didn't want it to give back large amounts since it used to blow up when ignited, giving back some sulphur, but since I changed that I may make it drop 4 at all times.