EmilsGithub / Clutter-Mod-Repository

The Github repository for the Minecraft mod Clutter
MIT License
6 stars 5 forks source link

[Suggestion] Candle item condensing #21

Open Ultimushadow opened 10 months ago

Ultimushadow commented 10 months ago

Last one for today, I promise 😅 I wanted to suggest an easier and more modular way for the candle based items Clutter adds, taking inspiration from Supplementaries. See, in Clutter, you've made an individual item for all 17 colors of candles, all 4 oxidization states as well as waxed copper variants, on top of iron, silver, and gold variant, and separate categories for wall holders, candelabras and chandeliers. All together that's 561 separate items which is... a lot. Now, while you could reduce the block amount by just adding a data value "color" and "material", you can also reduce the block amount - and the item amount - by merging the wall holder, chandelier, and candelabras into a single item. Here's how it works: Add a single crafting recipe for copper, iron, gold and silver candle holders. One candle over one ingot over one nugget. That gives you a {material} {candle color} Candle Holder. This item, when placed, acts like a candle does. Placing one gives you a candle holder with one candle. Click the block again, now you have two candles, again for three, again for four. Now place the candle holder on a wall and boom, it attached to the wall, can hold one to four candles, and if you place it on the ceiling it will be a chandelier with one to four candles. Here's how Supplementaries implemented it: 2023-08-13_07 27 14

Doing this means you don't have to destroy the players poor inventory, and you can get WAY more customizability out of these items. The textures can be made from the existing ones in the mod (which look great btw), and you can even take this one step further See, when I was messing with the mod, I noticed something pretty cool, which gave me an idea. You can place a candle directly on top of a candelabra and it makes it look like a tall candle: 2023-08-13_07 32 57 I was thinking that alongside the "Large" candle is a "Tall" candle, and clicking on any form of candle holder gives the candles that extra height! It can also be placed on it's own, 1-4 like regular candles (and maybe the Large candle can be stacked 2 high too!)

The block properties you would need to accomplish this: A property from 1-4 to track the candles A property with floor, wall and ceiling values to track the face A property with north/south/east/west which is already in your current blocks Waterlogged property, already in your blocks, but it should automatically extinguish the candles if true Lit property, already in your blocks, but it should be locked to false as long as waterlogged is true And finally a property with tall/short values for the tall candles I would also make things easy by including a "material" and "color" property so that it can be condensed to a single block, and for holders with a candle count of one, clicking with another material of candle holder could swap it/clicking with a different colored candle swaps the color

Breaking a candleholder with multiple candles drops a candle and reduced the candle property by 1 A tall candle holder can be sheared to drop the tall candle, and will drop the tall candle alongside the candle holder if the number of candles was 1