ls: symlinks should show the icon of the linked file

[GoogleCodeExporter]

with the attached patch ls shows the icon of the linked file for symbolic
links instead of a default blank icon.

btw. in that patch - why does 
 if (fobj.is_link):

not work instead of

 if (fobj.target_vfsstat != None):

Original issue reported on code.google.com by KaiSchro...@gmail.com on 24 Jan 2008 at 4:47

Attachments:

• symlink_icons.patch

[GoogleCodeExporter]

Looks good, thanks!

Committed r852
    M   hotwire/sysdep/fs_impl/fs_gnomevfs.py
r852 = 491ac9b240636c9e4687d57cdc7bde976adf8b6d (git-svn)

Original comment by cgwalt...@gmail.com on 24 Jan 2008 at 5:28

• Changed state: Fixed
• Added labels: Type-Patch
• Removed labels: Type-Defect

[GoogleCodeExporter]

sorry, although the patch seems to work, there is a small bug in the following 
line
(fobj.uri -> uri)

(result, flags) = gnome.ui.icon_lookup(self.__itheme, self.__thumbnails, 
fobj.uri,
file_info=stat, mime_type=stat.mime_type)

should read

(result, flags) = gnome.ui.icon_lookup(self.__itheme, self.__thumbnails, uri,
file_info=stat, mime_type=stat.mime_type)

Original comment by KaiSchro...@gmail.com on 24 Jan 2008 at 5:45

[GoogleCodeExporter]

I see it.  Added the secondary fix, thanks!

Committed r853
    M   hotwire/sysdep/fs_impl/fs_gnomevfs.py
r853 = bfab4fb84a18cfe6a599716078e867b8c05535f9 (git-svn)

Original comment by cgwalt...@gmail.com on 24 Jan 2008 at 6:17