EmilyDirsh / hotwire-shell

Automatically exported from code.google.com/p/hotwire-shell
Other
0 stars 0 forks source link

Change setup.py to run gtk-update-icon-cache #150

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Install hotwire
2. type help
3.

What is the expected output? What do you see instead?

Instead of the help output, I get traces from insert_pixbuf because the
icon wasn't found

What version of the product are you using? On what operating system?

0.710 (same from svn), installed by python setup.py install.  Ubuntu Gusty.

Please provide any additional information below.

Somehow the icons either don't exist, aren't being searched for properly or
aren't being installed correctly.  Regardless, it makes sense to carry on
without the icon and display the help.  Patch below works for me.

Original issue reported on code.google.com by mason.ch...@gmail.com on 13 Feb 2008 at 7:38

Attachments:

GoogleCodeExporter commented 9 years ago
This occurs when you install to the system without running 
gtk-update-icon-cache.  

I've gone to some effort to make sure you can run without doing any system 
install
(just run "python ui/hotwire").  See:
http://code.google.com/p/hotwire-shell/wiki/BuildingFromSubversion

I don't think we can really sanely handle the installed-but-broken case all 
through
the code.  The help pixbufs are just the first to fail.  

What we should probably do though to avoid this pitfall is to run
gtk-update-icon-cache in setup.py automatically.  

Original comment by cgwalt...@gmail.com on 13 Feb 2008 at 8:51

GoogleCodeExporter commented 9 years ago
Confirmed, gtk-update-icon-cache as root solved it (thanks!)

The help.py bits were the only problems I hit that made things difficult to 
use, I'd
suggest keeping my patch for the python ui/hotwire usage.  

The problem is that help doesn't work at all, so it is difficult to get an idea 
of
what the built in commands do, and hard to learn the system.

Original comment by mason.ch...@gmail.com on 13 Feb 2008 at 9:19

GoogleCodeExporter commented 9 years ago
We now run gtk-update-icon-cache if installing to a system root:

Committed r1172
    M   setup.py
r1172 = 23f31549838aa9523182c9addcaa9e3cb7579de2 (git-svn)

Original comment by cgwalt...@gmail.com on 23 Mar 2008 at 6:41