EmilyDirsh / hotwire-shell

Automatically exported from code.google.com/p/hotwire-shell
Other
0 stars 0 forks source link

A new builtin command 'exit' #159

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Here's a patch to implement 'exit', by activating the menu item 'File->Close'.

Original issue reported on code.google.com by Zeng.Shi...@gmail.com on 29 Feb 2008 at 9:21

Attachments:

GoogleCodeExporter commented 9 years ago
Looks OK to me.  One thing I've been trying to think about in a long term is 
having a
general meta-command (say "hot") that lets you do general UI things from a 
prefix.

For example, "hot inspector" would expand the inspector, etc.  This way we 
wouldn't
have to add a keybinding (or toplevel command) for everything.

But I think it does make sense to have a global "exit" to match Unix shells, so 
let's
go with this patch for now.

Thanks!

Original comment by cgwalt...@gmail.com on 29 Feb 2008 at 9:32

GoogleCodeExporter commented 9 years ago
Committed r1107
        A       hotwire/builtins/exit.py
        M       hotwire/builtin.py
r1107 = 0e6df0edb6b147ee117ce170a10322517f9c72d3 (trunk)

thanks for reviewing.

Original comment by Zeng.Shi...@gmail.com on 29 Feb 2008 at 9:39