A breadcrumbs/navigation address bar like in Nautilus or Vista

[GoogleCodeExporter]

Currently, going 'UP' or 'Back' is not convenient by mouse click. it has to
go to 'menu' -> 'Go' -> 'UP' 

Original issue reported on code.google.com by Zeng.Shi...@gmail.com on 29 Feb 2008 at 9:30

[GoogleCodeExporter]

A simple implementation with a screenshot is attached

Original comment by Zeng.Shi...@gmail.com on 2 Mar 2008 at 1:09

• Changed state: Started

Attachments:

• 0001-Issue-160-A-breadcrumbs-navigation-address-bar-lik.patch
• address.png

[GoogleCodeExporter]

an updated patch and screenshot.

Note the background color of the current working directory.

Original comment by Zeng.Shi...@gmail.com on 2 Mar 2008 at 3:51

Attachments:

• a-navigation-address-bar-with-highlight.patch
• address.png

[GoogleCodeExporter]

The third try, it now works on Linux.

Original comment by Zeng.Shi...@gmail.com on 2 Mar 2008 at 8:46

Attachments:

• address.png
• works_on_linux.patch

[GoogleCodeExporter]

This looks pretty nice.  Regarding the discussion on the discussion group, what 
do
you think about extending this to be a more general "navigation bar" or 
something
like that?  We could add things such as a Home button, the back/forward/up 
buttons, etc?

Original comment by cgwalt...@gmail.com on 3 Mar 2008 at 4:48

[GoogleCodeExporter]

I had the similar thought. Actually, it had a 'back' button at my first
implementation. Then, I just realized that this kind of things are exactly what 
a
toolbar does, so I asked in that thread if we need a toolbar.

Original comment by Zeng.Shi...@gmail.com on 3 Mar 2008 at 5:00

[GoogleCodeExporter]

Use the same logical as PathBar in GtkFileChooser.

Original comment by Zeng.Shi...@gmail.com on 6 Mar 2008 at 2:13

Attachments:

• 0001-Issue-160-A-breadcrumbs-navigation-address-bar-lik.patch
• address.png

[GoogleCodeExporter]

Do you see this being enabled all the time?  I'm leaning towards it being 
toggle-able
from View, like the inspector is.  

I'm kind of curious - how do you navigate directories?  Do you use forward/back
(Alt-LeftArrow,Alt-RightArrow) at all right now?  Do you use Quick Find 
(Alt-Down)?

On the patch, just one minor thing I see right now:

+        self.__dir_name = escape(label)

I'd keep self.__dir_name being unescaped; so just: 
self.__dir_name = label

+        layout.set_markup("%s" % self.__dir_name)

Then:
layout.set_markup("%s" % escape(self.__dir_name))

That way the __on_click handler can just use self.__dir_name instead of taking 
the
path argument.  I think it's cleaner to have the data structures inside a 
widget be
in their normal form instead of XML, and only escape it when you need to.

Original comment by cgwalt...@gmail.com on 7 Mar 2008 at 8:49

[GoogleCodeExporter]

Yes, toggle-able would be the way to go.

No, I don't use too much 'Alt-*Arrow', because I usually use mouse to change 
working
directory, and I hate to switch between keyboard and mouse. Maybe I need train 
myself
to get used to using keyboard for this kind of tasks

Using escaped name in __dir_name is simply a consideration of efficiency, as 
such we
don't need to escape every time when the button is toggled. Anyway, it's fine 
to me
to save an unescaped name, if you prefer.

As for, an unescaped dirname is not enough, we need an absolute path for the
directory, because we may jump over directories. 

Original comment by Zeng.Shi...@gmail.com on 7 Mar 2008 at 9:45

[GoogleCodeExporter]

Here's an updated patch which adds a toggle option.

I'm still not sure I like the flow though.  Do we want the navigation bar 
display to
be persistent, so if you toggle it on then it's on the next time you restart 
Hotwire?
 Should it be on if you create a new tab?  Should it depend on whether it was visible
in the creating tab?

Here's one idea - don't have an option, but automatically display the navbar 
for when
the current display is showing a FileOpBuiltin.  Actually - how about we make 
it part
of FilePathRenderer?

Original comment by cgwalt...@gmail.com on 12 Mar 2008 at 2:47

Attachments:

• navbar-toggleable.patch

[GoogleCodeExporter]

One question about the patch itself: why is the menu under 'go'? I expected it 
to be
under 'view'.

I think we need to remember the state when it exits and restore the behavior 
when it
is restarted. As for the new tabs, I think we only need to follow the global 
setting.
Even if we are able to toggle that for each individual tab, I doubt people 
would use
it to toggle one on and the other off.

I don't think I'm competent to comment on the FileOpBuiltin part. 

Original comment by Zeng.Shi...@gmail.com on 13 Mar 2008 at 9:52

[GoogleCodeExporter]

here's another try.

now the state is remembered. and it is under 'View'

Original comment by Zeng.Shi...@gmail.com on 16 Mar 2008 at 6:50

Attachments:

• 0001-Issue-160-A-breadcrumbs-navigation-address-bar-lik.patch
• 0002-Make-the-addressbar-toggle-able-patch-from-Colin.patch
• 0003-Rename-__dir_name-to-__escaped_dir_name.patch
• 0004-move-the-menu-item-navigation-bar-from-Go-to-Vi.patch
• 0005-A-new-ViewState-class-to-remember-the-state-of-menu.patch
• 0006-Append-an-init-function-to-ui_pairs.patch
• 0007-rename-address-bar-to-navigation-bar-for-consist.patch

[GoogleCodeExporter]

Actually, with 'ViewState', we can remember the state of 'Fullscreen' or 
'inspector'.
do you think does that make any sense?

Original comment by Zeng.Shi...@gmail.com on 16 Mar 2008 at 6:56

[GoogleCodeExporter]

Colin, I just noticed that addressbar.py was added to svn trunk at revision 
1119, but
it doesn't function and wasn't mentioned in the svn log, so I think it's 
unintended,
right?

Original comment by Zeng.Shi...@gmail.com on 19 Mar 2008 at 6:39

[GoogleCodeExporter]

Oops, yeah that was not intentional.

I'll have a look at these patches shortly.  For some reason I wasn't getting 
email
about updates to this issue!

Original comment by cgwalt...@gmail.com on 21 Mar 2008 at 5:12

[GoogleCodeExporter]

Ok, all of these patches look pretty good - I want to try to cut the 0.720 
release
though today though and it's a lot of code change.  Can we postpone this to just
after that release?

Sorry about not getting to them in time; it is strange, I searched through my 
GMail
and I couldn't find a notification about an update to this issue, until comment 
13.  

Original comment by cgwalt...@gmail.com on 23 Mar 2008 at 5:47

[GoogleCodeExporter]

That's fine. I'll submit these after .720 is out.

Original comment by Zeng.Shi...@gmail.com on 23 Mar 2008 at 5:55

[GoogleCodeExporter]

committed
r1180-r1184

Original comment by Zeng.Shi...@gmail.com on 24 Mar 2008 at 3:51

• Changed state: Fixed