EmilyDirsh / hotwire-shell

Automatically exported from code.google.com/p/hotwire-shell
Other
0 stars 0 forks source link

Native icons on win32 #165

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently, there are only two types of icons rendered on windows system:
gtk-directory and gtk-file. We need to render it using the native icons.

Original issue reported on code.google.com by Zeng.Shi...@gmail.com on 17 Mar 2008 at 2:00

GoogleCodeExporter commented 9 years ago
 Attached are a screenshot and a rough patch.

the patch is a simplified python version of the corresponding function in
gtkfilesystemwin32.[ch] in gtk. A private function is used, because I don't want
rewrite it in python.

Original comment by Zeng.Shi...@gmail.com on 17 Mar 2008 at 2:01

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by Zeng.Shi...@gmail.com on 17 Mar 2008 at 2:02

GoogleCodeExporter commented 9 years ago
+except:
+    cgtk = None
+    cgdk = None
+    cgdk_pixbuf

This will be a syntax error if the import fails, right?

Otherwise this patch looks good to me, please commit!

Original comment by cgwalt...@gmail.com on 17 Mar 2008 at 9:59

GoogleCodeExporter commented 9 years ago
Thanks for reviewing, that's really a stupid typo.

committed a slightly revised version, accounting for the possible exception 
because
of the private function.

Committed r1153
        M       hotwire/sysdep/fs_impl/fs_win32.py
r1153 = e57ee81de60e4998e7101584d50d7be868301dfd (trunk)

Original comment by Zeng.Shi...@gmail.com on 17 Mar 2008 at 10:53