avoid failures if gtk icon cache busted

[GoogleCodeExporter]

I seem to have a badly configured image cache such that images can't be 
loaded.  While sub-optimal, this shouldn't be fatal: the attached prevents 
crashing, although more logging might be adviseable.

Original issue reported on code.google.com by qu...@sparq.org on 26 Mar 2008 at 8:05

Attachments:

• 02nohelppixbuf.patch

[GoogleCodeExporter]

If you don't have a working image cache, a lot more code besides the help 
display is
going to break.  The pipeline status spinner, the directory icons....

I don't think we can try to support working under such a condition; or at least 
to do
so, this patch is incomplete.

Original comment by cgwalt...@gmail.com on 26 Mar 2008 at 11:10

[GoogleCodeExporter]

I haven't tracked down why I don't have the particular image needed here, but 
aside 
from a blank hotwire button on the bottom row and a blank image on the help 
display, 
everything else seems to work fine.  

I understand your reticence to run without the full feature experience, but 
quite 
honestly, if this startup fragility hadn't been easy to workaround, that 
probably 
would have meant the end of my interest in hotwire: there's so much stuff out 
there 
and much of it is not well executed, so it's important to at least get past 
startup 
to show people what's going on and keep their interest.

This patch may not be as complete as it should be, but it's a start.  I don't 
have 
the familiarity with hotwire internals at this point to extend the patch, but 
I'd 
urge you to continue with it.

</end soapbox>

Nice tool so far!

Original comment by qu...@sparq.org on 26 Mar 2008 at 4:53

[GoogleCodeExporter]

Fair enough - I guess a shell should try to be resilient against failure in the 
rest
of the system because you might be trying to bring it up for recovery.

Original comment by cgwalt...@gmail.com on 26 Mar 2008 at 5:35

• Changed title: avoid failures if gtk icon cache busted
• Changed state: Accepted

[GoogleCodeExporter]

Great!

BTW, the phrase "there's so much stuff out there and much of it is not well 
executed" wasn't a reference to Hotwire, but to the number of 
publicly-available 
projects (visible via sites like Freshmeat).

Original comment by qu...@sparq.org on 26 Mar 2008 at 6:42

[GoogleCodeExporter]

This patch may help, not tested:

Committed r1196
    M   hotwire_ui/pixbufcache.py
r1196 = 52bdb7e07ccba8ecc3406701fec5760ca700ad3b (git-svn)

Original comment by cgwalt...@gmail.com on 29 Mar 2008 at 1:17

[GoogleCodeExporter]

It's not pretty, but it mostly works:

Committed r1199
    M   hotwire_ui/shell.py
    M   hotwire_ui/pixbufcache.py
r1199 = 4ac77127473edce49aec8e68a0dd4f92213ad1bd (git-svn)

Original comment by cgwalt...@gmail.com on 29 Mar 2008 at 1:57

• Changed state: Fixed