EmilyDirsh / hotwire-shell

Automatically exported from code.google.com/p/hotwire-shell
Other
0 stars 0 forks source link

"help xyz" leaves icon running #186

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. type "help xyz" as your command

What is the expected output? What do you see instead?

Expect to see nothing, or an error message that the command is not known. 
And in particular, when it is completed, the running icon (dots in circle
animation) should change to the grey dots in a circle indicating it has
finished.

Instead the animation continues.  The text underneath the command reports
that the command is "Complete", as does the list of commands.  It is only
the animation that is out of step.

What version of the product are you using? On what operating system?

Latest from svn (rev 1247, version 0.723).  On Ubuntu 8.04 x86_64

Original issue reported on code.google.com by dmi...@gmail.com on 8 May 2008 at 6:33

GoogleCodeExporter commented 9 years ago
Looked at the code, and the method in question appears to be 

__on_pipeline_state_change() in hotwire_ui/command.py  

It looks perfectly reasonable so I wonder if there is a bug in gtk.Image where 
the
second call (to set_from_pixbuf() ) is ignored if the first call has not 
completed
yet.  A quick google doesn't reveal anything though ...

Original comment by dmi...@gmail.com on 8 May 2008 at 9:04

GoogleCodeExporter commented 9 years ago
How reproducible is this issue?  I can't seem to make it happen on my system.

Original comment by cgwalt...@gmail.com on 19 May 2008 at 12:09

GoogleCodeExporter commented 9 years ago
Just tried again and it is still there.  I tried running it a separate instance,
using 'hotwire -n' and got the following output in my original window

18:05:11 [140115555391200] root ERROR Exception in idle
Traceback (most recent call last):
  File "/home/mish/dev/hotwire/hotwire/mainloop_g.py", line 28, in _run_logging
    return f(*args)
  File "/home/mish/dev/hotwire/hotwire/async.py", line 109, in __do_idle
    return handler(self, *self.__handler_args)
  File "/home/mish/dev/hotwire/hotwire_ui/odisp.py", line 381, in __idle_handle_output
    odisp.append_object(item, **append_kwargs)
  File "/home/mish/dev/hotwire/hotwire_ui/odisp.py", line 189, in append_object
    self.__display.append_obj(obj, **kwargs)
  File "/home/mish/dev/hotwire/hotwire_ui/renderers/help.py", line 181, in append_obj
    self.__help_items(o.items)
  File "/home/mish/dev/hotwire/hotwire_ui/renderers/help.py", line 168, in __help_items
    builtin = builtins[name]
  File "/home/mish/dev/hotwire/hotwire/builtin.py", line 170, in __getitem__
    raise KeyError(name)
KeyError: u'xyz'

I imagine that is expected, but there it is, in case it matters.  If anyone else
reading this can try it we might see if there is some common factor - ubuntu?  
64 bit
version? ...

Original comment by dmi...@gmail.com on 20 May 2008 at 5:08

GoogleCodeExporter commented 9 years ago
Would you like the versions of any of my python or gtk libraries?

Original comment by dmi...@gmail.com on 22 May 2008 at 1:24

GoogleCodeExporter commented 9 years ago
Ohh sorry I read the original report too quickly.  I thought you were saying it 
was
an error for known builtins like 'cd', not unknown.

Fixed now:
Committed r1253
    M   hotwire/builtins/help.py
    M   hotwire_ui/renderers/help.py
r1253 = 7628395dca04251238ea8f1a994b3a07ea82868b (git-svn)

Original comment by cgwalt...@gmail.com on 23 May 2008 at 12:43