search

EmiyaSyahriel / CrossLauncher

XMB-like Android Launcher
MIT License
99 stars 7 forks source link

make <= 100px bitmap icons less blurry and unify their sizes #71

Closed Kethen closed 12 months ago

Kethen commented 12 months ago

Unify icons bitmap size to 300x300, the largest size as far as I can find in the current codebase

Fixes blurriness of icons with 50x50 and 100x100 bitmaps

EmiyaSyahriel commented 12 months ago

Have you checked how much these 300x300 bitmaps RAM costs?

The reason why I made it 50x50 and 100x100 originally is because of RAM usage constraint in addition to how bitmap loading works at the time. Bitmap loading might've been a little bit better now (i'm not remember if this loading is also done to built-in icons, though), But just to be sure it does not require more than 500MB of Java Heap+Non-shared Native RAM.

Kethen commented 12 months ago

I haven't noticed memory leakage so far on Essential Phone PH-1 running android 13 based LMODroid, tho I don't keep the fps/memory display constantly on

EmiyaSyahriel commented 12 months ago

Oh ok, seems like not much impact on RAM usage, I'll merge it.

Now, I just thought of a "Texture Quality" setting to adjust these sizes. But, in the meantime, let's go with this.