Emkay16 / pe

0 stars 0 forks source link

Adding an existing component when weightage is already at 100 will not overwrite old data even if weightage does not cause total to exceed 100 #2

Open Emkay16 opened 3 years ago

Emkay16 commented 3 years ago

Old components' weightages are supposed to be overwritten when a component with an existing name is added. However, when the total weightage already adds up to a hundred, trying to overwrite a component to a lower weightage does not work. The error states that the weightage cannot be negative or exceed a hundred, but overwriting a component to a lower weightage would not result in either.

image.png image.png (30 + 30 + 15 + 15 = 90)

nus-pe-bot commented 3 years ago

Team's Response

Thank you for letting us know the bug :)

This may cause you minor inconvenience in situation like this. However, you may edit your component's weightage by setting it as 0 first, before setting it as the lower weightage you chose to change to.

Nonetheless, we recognise this and will make improvement on this in our future implementation.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I believe this can cause occasional inconveniences, as changes in weightage are not exactly rare. The user is unlikely to be aware that such changes can be made by setting a component's weightage to 0 first as this does not seem to be mentioned in the user guide or in the application.

Perhaps including this in the user guide would give a good reason to lower the severity to low.