Emma-MacK / Software_assessment

A repository to hold the work I do for university
Apache License 2.0
0 stars 1 forks source link

add make bed to tools.py, correct error in calling panel #36

Closed Emma-MacK closed 9 months ago

Emma-MacK commented 9 months ago
Emma-MacK commented 9 months ago

The arguments needed for "get bed" personalisation have been hardcoded, but can be turned to command line arguments later

EKPayne commented 9 months ago

Line 139 of functions.py for HGNC in HGNC_list: full_url = url_base + str(HGNC)+ transcript_filter

HGNC should be lower case. Added here as a separate comment as this was added in a previous commit and I am therefore unable to comment directly within the code.

EKPayne commented 9 months ago

Additional thought: recommend adding timeout arguments for any request.get statements

Emma-MacK commented 9 months ago

I have make the requested changes. Additionally I have added some error handling if the panelapp query returns an empty json meaning there are no HGNC IDs to extracts, and if the NGTD indicates genomewide testing, which leads to a syntax error while trying to extract HGNC IDs

Emma-MacK commented 9 months ago

Additional thought: recommend adding timeout arguments for any request.get statements

I have added timeout arguments to the get requests

Emma-MacK commented 9 months ago

I have resolved the merge conflicts

EKPayne commented 9 months ago

One additional note. It looks like json is imported twice in functions.py. Remove once.

Emma-MacK commented 9 months ago

requested changes have been made

EKPayne commented 9 months ago

Happy that all requested corrections have been addressed. Branch merged into developed. Pull request can be closed.