Closed Emma-MacK closed 9 months ago
The arguments needed for "get bed" personalisation have been hardcoded, but can be turned to command line arguments later
Line 139 of functions.py
for HGNC in HGNC_list:
full_url = url_base + str(HGNC)+ transcript_filter
HGNC should be lower case. Added here as a separate comment as this was added in a previous commit and I am therefore unable to comment directly within the code.
Additional thought: recommend adding timeout arguments for any request.get statements
I have make the requested changes. Additionally I have added some error handling if the panelapp query returns an empty json meaning there are no HGNC IDs to extracts, and if the NGTD indicates genomewide testing, which leads to a syntax error while trying to extract HGNC IDs
Additional thought: recommend adding timeout arguments for any request.get statements
I have added timeout arguments to the get requests
I have resolved the merge conflicts
One additional note. It looks like json is imported twice in functions.py. Remove once.
requested changes have been made
Happy that all requested corrections have been addressed. Branch merged into developed. Pull request can be closed.