EmmanuelBeziat / vscode-great-icons

🆚 A big pack of icons (200+) for your files
https://marketplace.visualstudio.com/items?itemName=emmanuelbeziat.vscode-great-icons
MIT License
163 stars 58 forks source link

Add Visual Foxpro icon #101

Closed mdacunha90 closed 6 years ago

mdacunha90 commented 6 years ago

http://www.congruentsoft.com/visual-foxpro-to-dot-net-migration.aspx

foxpro-icon

EmmanuelBeziat commented 6 years ago

Hi @mdacunha90 ,

I need to know the file extensions to be used with the icon. Can you make a list of them?

Thanks.

mdacunha90 commented 6 years ago

Hi @EmmanuelBeziat

The file extensions to be used with the icon are:

Thanks.

EmmanuelBeziat commented 6 years ago

Hi,

Check out the new v2.1.28!

Thanks for making VSCode Great Icons a better set! :)

APerricone commented 6 years ago

Hi mdacunha90, do you use visual foxpro? with my extension the prg file are harbour/xHarbour file and the image is another https://harbour.github.io/logo Anyway, for me is ok see a fox on prg files and this theme is great. maybe you can keep fox for fxp file and add the boat for the prg and ch file... I am just curious about foxpro...

EmmanuelBeziat commented 6 years ago

Hi @APerricone

Yeah, that's the problem about extensions files
 😞 I might try to add a poll for that, but I'm not sure people would come by to check, especially if many don't know this filetype.

I didn't know about foxpro and harbour before this topic, but I might add them both and use the most used for .prg.

By the way, I can add Harbour anyway, what are the other files extensions it use?

@mdacunha90 do you have a view on that?

APerricone commented 6 years ago

Hello, they are both dialect of clipper, so have the same extension... for me is ok the default icon for prg file, i was surprise about the fox :) About the "what is more used?" if you search an extension for foxpro for vsCode there is none, for harbor there are the mine and other 2, and the mine has 3K download in harbour we have:

Thank you for your work and for your kindess

mdacunha90 commented 6 years ago

Hi @APerricone https://github.com/aperricone,

Yes I use Foxpro in a daily bases at my job with my 3 collegues.

Cordialement, Mit freundlichen GrĂŒĂŸen, Best Regards, Mat frĂ«ndleche GrĂ©iss, Mickael GOMES


[image: Afficher l'image d'origine]

Zone Industrielle Riedgen

Ancien Site WSA

L-3451 Dudelange

Tel. : +352.51.22.32.165

Numéro court : 352 165


​[image: https://lh5.googleusercontent.com/QEV3br2N5HcJHrOdDxHPD9-Lh2ZaEn6pwfZsCQ0t5T1d8E0wVjbQDCPv8OSMVcFHirbJ5JzxjmdVWu75PoZxd2Lf69vPUSSR0n6sON2RNayG0ONsj4iNJMxsAQ] Avant d'imprimer, pensez Ă  l'environnement ! Cet e-mail est destinĂ© exclusivement aux personnes dont le nom figure ci-dessus. Il peut contenir des informations protĂ©gĂ©es par le secret professionnel et dont la divulgation est strictement prohibĂ©e. Si vous avez reçu cet e-mail par erreur, nous vous remercions de bien vouloir le dĂ©truire immĂ©diatement et de nous en informer par e-mail. This e-mail is intended for the above-mentioned addressees only. It may contain privileged or confidential information, the review, dissemination or disclosure of which is strictly prohibited. If you have received this e-mail by mistake please immediately destroy it and so inform us by e-mail.

2018-03-11 16:18 GMT+01:00 Antonino Perricone notifications@github.com:

Hello, they are both dialect of clipper, so have the same extension... for me is ok the default icon for prg file, i was surprise about the fox :) It is not necessary work for it 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EmmanuelBeziat/vscode-great-icons/issues/101#issuecomment-372123076, or mute the thread https://github.com/notifications/unsubscribe-auth/APdn8x6MC1eFmZcflHQe26N4hyrI5B_Wks5tdUBMgaJpZM4SYEOJ .

APerricone commented 6 years ago

Hi Mickael, Me and other 3.400 users use harbor with vscode. my extension register the filetype harbour, maybe if it is not installed this filetype does not exist and maybe it is possible say "if the extension is prg put the fox, if the file type is harbour put other icon" in this case only who have the extension installed see the other icon... Or, to avoid discussion, put the default icon. Antonino

mdacunha90 commented 6 years ago

Hi,

I don't know how much people use foxpro in vscode, I just can say that it is a Microsoft product and that there is a french community of professional users that counts 3815 members.

Cordialement, Mit freundlichen GrĂŒĂŸen, Best Regards, Mat frĂ«ndleche GrĂ©iss, Mickael GOMES


[image: Afficher l'image d'origine]

Zone Industrielle Riedgen

Ancien Site WSA

L-3451 Dudelange

Tel. : +352.51.22.32.165

Numéro court : 352 165


​[image: https://lh5.googleusercontent.com/QEV3br2N5HcJHrOdDxHPD9-Lh2ZaEn6pwfZsCQ0t5T1d8E0wVjbQDCPv8OSMVcFHirbJ5JzxjmdVWu75PoZxd2Lf69vPUSSR0n6sON2RNayG0ONsj4iNJMxsAQ] Avant d'imprimer, pensez Ă  l'environnement ! Cet e-mail est destinĂ© exclusivement aux personnes dont le nom figure ci-dessus. Il peut contenir des informations protĂ©gĂ©es par le secret professionnel et dont la divulgation est strictement prohibĂ©e. Si vous avez reçu cet e-mail par erreur, nous vous remercions de bien vouloir le dĂ©truire immĂ©diatement et de nous en informer par e-mail. This e-mail is intended for the above-mentioned addressees only. It may contain privileged or confidential information, the review, dissemination or disclosure of which is strictly prohibited. If you have received this e-mail by mistake please immediately destroy it and so inform us by e-mail.

2018-03-12 9:18 GMT+01:00 Antonino Perricone notifications@github.com:

Hi Mickael, Me and other 3.400 users use harbor with vscode. my extension register the filetype harbour, maybe if it is not installed this filetype does not exist and maybe it is possible say "if the extension is prg put the fox, if the file type is harbour put other icon" in this case only who have the extension installed see the other icon... Or, to avoid discussion, put the default icon. Antonino

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EmmanuelBeziat/vscode-great-icons/issues/101#issuecomment-372225739, or mute the thread https://github.com/notifications/unsubscribe-auth/APdn8zNY5goAmp_HS8RD6peKs1O9950Eks5tdi9PgaJpZM4SYEOJ .

APerricone commented 6 years ago

Hi, There is no new version from 2007 I think the better solution is put the default icon for prg files. Antonino

EmmanuelBeziat commented 6 years ago

Hi,

As it's possible to have icons by environment rather than by file extension, I'll try to have the both icons working for their respective workspace.

By default, I'll put the Harbor icon on .prg files, as it's still maintained.

EmmanuelBeziat commented 6 years ago

It's done, check out the new version. Thanks!

mdacunha90 commented 6 years ago

Hello,

I now have the harbor logo and I'm using foxpro!

So many people using using harbor as Antonino said but no one ever asked for it until I asked for the Foxpro icon.

Cordialement, Mit freundlichen GrĂŒĂŸen, Best Regards, Mat frĂ«ndleche GrĂ©iss, Mickael GOMES


[image: Afficher l'image d'origine]

Zone Industrielle Riedgen

Ancien Site WSA

L-3451 Dudelange

Tel. : +352.51.22.32.165

Numéro court : 352 165


​[image: https://lh5.googleusercontent.com/QEV3br2N5HcJHrOdDxHPD9-Lh2ZaEn6pwfZsCQ0t5T1d8E0wVjbQDCPv8OSMVcFHirbJ5JzxjmdVWu75PoZxd2Lf69vPUSSR0n6sON2RNayG0ONsj4iNJMxsAQ] Avant d'imprimer, pensez Ă  l'environnement ! Cet e-mail est destinĂ© exclusivement aux personnes dont le nom figure ci-dessus. Il peut contenir des informations protĂ©gĂ©es par le secret professionnel et dont la divulgation est strictement prohibĂ©e. Si vous avez reçu cet e-mail par erreur, nous vous remercions de bien vouloir le dĂ©truire immĂ©diatement et de nous en informer par e-mail. This e-mail is intended for the above-mentioned addressees only. It may contain privileged or confidential information, the review, dissemination or disclosure of which is strictly prohibited. If you have received this e-mail by mistake please immediately destroy it and so inform us by e-mail.

2018-03-18 14:51 GMT+01:00 Emmanuel BĂ©ziat notifications@github.com:

Closed #101 https://github.com/EmmanuelBeziat/vscode-great-icons/issues/101 via 5f2c59a https://github.com/EmmanuelBeziat/vscode-great-icons/commit/5f2c59a68d77a8dbc6087c525ff1362d8ac6b1ea .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EmmanuelBeziat/vscode-great-icons/issues/101#event-1527241340, or mute the thread https://github.com/notifications/unsubscribe-auth/APdn860FU5emWm6HfvCwes11j3UmxffGks5tfmZ-gaJpZM4SYEOJ .

APerricone commented 6 years ago

Thank you Emmanuel but I propose to remove the prg association. there is a lot of dialect:

and all uses prg extension...

EmmanuelBeziat commented 6 years ago

Then I'll just put a simple grind.

Check the new v2.1.30.