search

EmmanuelBeziat / vscode-great-icons

🆚 A big pack of icons (200+) for your files
https://marketplace.visualstudio.com/items?itemName=emmanuelbeziat.vscode-great-icons
MIT License
158 stars 56 forks source link

[BUG] No Prettier icon for .prettierrc.cjs #244

Closed amokmen closed 1 year ago

amokmen commented 1 year ago

Subj.

Ubuntu 18, VSCode 1.73, VSCode Great Icons 2.1.86

Screenshot: image

Clm-Roig commented 1 year ago

Same here on Windows 10, v2.1.86.

More precisely, all prettier file names don't work except one : .prettierrc

There was a recent PR about Prettier (#239) but I don't see anything wrong with it...

Clm-Roig commented 1 year ago

Maybe there is a conflict between prettierrc in the fileExtensions section : https://github.com/EmmanuelBeziat/vscode-great-icons/blob/889d892c627b4a703dab103fd7ef5886b7c436f8/icons.json#L1089

And all the prettierrc in the fileNames section below ? https://github.com/EmmanuelBeziat/vscode-great-icons/blob/889d892c627b4a703dab103fd7ef5886b7c436f8/icons.json#L1392-L1401

Prettier is the only tool which has this pattern (extension + fileName) maybe ? Not sure at 100%, I didn't search and find every extension 😅

EmmanuelBeziat commented 1 year ago

Hi, sorry for the long delay. Check out the new v2.1.88!