EmmanuelBeziat / vscode-great-icons

🆚 A big pack of icons (200+) for your files
https://marketplace.visualstudio.com/items?itemName=emmanuelbeziat.vscode-great-icons
MIT License
158 stars 56 forks source link

Better icon for YAML files #250

Open binaryfire opened 1 year ago

binaryfire commented 1 year ago

Hi there. Great extension!

I've noticed that .yml files are not recognised as YAML files. .yml is a valid alternative to .yaml and is commonly used. Would you be able to add this?

EmmanuelBeziat commented 1 year ago

Hi, thanks!

yml extension is supposed to be supported :

It might happen that some file formats are not taken in account sometimes, maybe try to change the icon set in your settings and get it back to see if it changes?

Let me know how it went.

binaryfire commented 1 year ago

@EmmanuelBeziat Hi! Yeah that’s what I’m seeing. But I’ve never seen that icon before.

I was expecting the same icon as .yaml files (like this: https://thenounproject.com/browse/icons/term/yaml-file-document-icon/). Both file extensions refer to YAML (Yet Another Markup Language) so wouldn’t it be better to use the same icon?

See: https://docs.fileformat.com/programming/yml/

ChetSocio commented 1 year ago

Yml and both yaml are working on my side too.

image

binaryfire commented 1 year ago

As I said, it's just regarding the red {...} icon. I've never seen it before and find it a bit distracting when you're dealing with large numbers of yml files. Just my opinion though...

It's a different icon to the standard yaml icon you see in most IDEs: https://thenounproject.com/browse/icons/term/yaml/

gotham8x commented 1 year ago

+1, I would recommend using different icons for YAML to convey a clearer meaning. The current one is not very meaningful for YAML. binaryfire's suggestion icons look good.

EmmanuelBeziat commented 2 months ago

Hello @binaryfire @gotham8x

I've been thinking about this. I'm not too much into the "binary" style with documents, it's a bit of a rabbit hole. I just published a new idea for the yaml icon, tell me how you feel about it.

I'm currently on a full rework of the core, to provide settings and customization for users. I can't provide any ETA, but the plan is to allow people to change an icon they dislike in their local conf.