search

EmmanuelBeziat / vscode-great-icons

🆚 A big pack of icons (200+) for your files
https://marketplace.visualstudio.com/items?itemName=emmanuelbeziat.vscode-great-icons
MIT License
163 stars 56 forks source link

golang icon should be different #274

Closed radoslew closed 1 year ago

radoslew commented 1 year ago

I have the impression that this icon is not very intuitive and poorly distinguished (on many monitors it simply looks like a blue spot). Classic GO icon from "VSCode Icons" is much more ergonomic in my opinion! What do you think?

EmmanuelBeziat commented 1 year ago

Hi! I'll check that and eventually revamp the icon :)

radoslew commented 1 year ago

Once again EB - maybe let's just use the classic icon? I think it is much more recognizable, distinguishable and ergonomic on smaller screens/resolutions. "Gopher" is nice, but it's really not the best icon in this case. I think my arguments are also reasonable and it's not just "this icon is ugly - you should change it to the one I like!" - we have to make compromises for the greater good! We can also add a white brorders to this logo - this would probably look even cooler and better. Cheers mate! golang-1

EmmanuelBeziat commented 1 year ago

@radoslew Hi,

It has now been updated, check out the new 2.1.99 version ! :)

jzksnsjswkw commented 1 year ago

@radoslew Hi,

It has now been updated, check out the new 2.1.99 version ! :)

I saw this new icon in today's update, and it does improve visibility compared to the old icon. However, I don't agree with the additional white border. It looks like an unclean cutout and doesn't harmonize well with themes that have non-white background colors, such as this Tab image. I hope the white border can be removed. Thank you.

截屏2023-09-18 18 34 08
radoslew commented 1 year ago

@radoslew Hi,

It has now been updated, check out the new 2.1.99 version ! :)

I saw this new icon in today's update, and it does improve visibility compared to the old icon. However, I don't agree with the additional white border. It looks like an unclean cutout and doesn't harmonize well with themes that have non-white background colors, such as this Tab image. I hope the white border can be removed. Thank you. ![Uploading 截屏2023-09-18 18.34.08.png…]()

100% agree. White border make it look bad. VSCode Icons pack has a nice looking one - maybe let's just get inspired?

EmmanuelBeziat commented 1 year ago

I saw this new icon in today's update, and it does improve visibility compared to the old icon. However, I don't agree with the additional white border. It looks like an unclean cutout and doesn't harmonize well with themes that have non-white background colors, such as this Tab image. I hope the white border can be removed. Thank you.

Seeing it live, it indeed looked unclean. I removed the border, let me know how it is now (v2.1.100).

jzksnsjswkw commented 1 year ago

I saw this new icon in today's update, and it does improve visibility compared to the old icon. However, I don't agree with the additional white border. It looks like an unclean cutout and doesn't harmonize well with themes that have non-white background colors, such as this Tab image. I hope the white border can be removed. Thank you.

Seeing it live, it indeed looked unclean. I removed the border, let me know how it is now (v2.1.100).

It looks much better now! If I had to point out any flaws, it would be perfect if it could be slightly enlarged and the color could be darkened just a bit. This is because in the Go project, there is a "gomod" file, and it doesn't have a specific icon, making it look inconsistent with the Go files. This is a minor flaw that can be changed or left as it is; it's already looking great.

radoslew commented 1 year ago

Now it's fine, but I agree with @jzksnsjswkw in terms of size and color. Also please remember about #270 - you promised to add more icons there ;)

EmmanuelBeziat commented 1 year ago

@jzksnsjswkw I just pushed a new version, that should do it. Also added support for the go.mod file. :)

jzksnsjswkw commented 1 year ago

It looks much better now :). However, "gomod" and "gosum" are dependency management files for Go projects, not code files. Using the same icon can be confusing. You can differentiate them by changing their colors, similar to the "Material Icon Theme" theme.