search

EmmanuelDemey / eslint-plugin-angular

ESLint plugin for AngularJS applications
https://www.npmjs.com/package/eslint-plugin-angular
618 stars 131 forks source link

Rule `typecheck-object` is wrongly failed for simple comparing with 'object' #509

Open Valdermeyder opened 7 years ago

Valdermeyder commented 7 years ago

Rule typecheck-object is wrongly failed for simple comparing with 'object' string

var variable = 'object';
return variable === 'object'

Same issue with other typecheck-* rules

I have opened the same issue some time ago but looks like it was wrongly interpreted. As for me, tests added in commit shouldn't show errors. I think it is no sense to show error when typeof is not used before the variable name. In the project where I work, we have our own business "types" which are described by some object's property. And because of this rule we need put /eslint angular/typecheck-object: 0/ in a lot of places Or at least there should be an option to disable such restrict check of type.