EmmanuelDemey / eslint-plugin-angular

ESLint plugin for AngularJS applications
https://www.npmjs.com/package/eslint-plugin-angular
618 stars 131 forks source link

Add support for enforcing angular.mock.module #567

Open tomratcliffe opened 5 years ago

tomratcliffe commented 5 years ago

This is needed when migrating angular.js to use webpack, and the existing unit tests call module('myModule'). This causes problems as module is a reserved/special word for webpack use, and the unit tests won't compile (complaining that module is not a function). The solution is to use angular.mock.module('myModule'). This rule change adds a webpack-support option (open to renaming this), and adds a fixer that can sort out the problems found (to save on Ctrl+F'ing through the code and finding issues).

Please see the following for more context/examples: https://stackoverflow.com/questions/32499108/karma-jasmine-webpack-module-is-not-a-function https://stackoverflow.com/questions/39360164/module-is-not-a-function-karma-jasmine-webpack-angular?rq=1

tomratcliffe commented 5 years ago

Hi @EmmanuelDemey, have you had a chance to look at this yet? Thanks!